Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Bump highlight.js from 9.18.5 to 10.4.1 #378

Merged
merged 1 commit into from
Feb 12, 2021
Merged

[Security] Bump highlight.js from 9.18.5 to 10.4.1 #378

merged 1 commit into from
Feb 12, 2021

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Dec 4, 2020 •
edited
Loading

Bumps highlight.js from 9.18.5 to 10.4.1. This update includes a security fix.

Vulnerabilities fixed

Sourced from The GitHub Security Advisory Database.

ReDOS vulnerabities: multiple grammars

Impact: Potential ReDOS vulnerabilities (exponential and polynomial RegEx backtracking)

oswasp:

> The Regular expression Denial of Service (ReDoS) is a Denial of Service attack, that exploits the fact that most Regular Expression implementations may reach extreme situations that cause them to work very slowly (exponentially related to input size). An attacker can then cause a program using a Regular Expression to enter these extreme situations and then hang for a very long time.

If are you are using Highlight.js to highlight user-provided data you are possibly vulnerable. On the client-side (in a browser or Electron environment) risks could include lengthy freezes or crashes... On the server-side infinite freezes could occur... effectively preventing users from accessing your app or service (ie, Denial of Service).

This is an issue with grammars shipped with the parser (and potentially 3rd party grammars also), not the parser itself. If you are using Highlight.js with any of the following grammars you are vulnerable. If you are using highlightAuto to detect the language (and have any of these grammars registered) you are vulnerable.

All versions prior to 10.4.1 are vulnerable, including version 9.18.5.

Grammars with exponential backtracking issues:

  • c-like (c, cpp, arduino)
  • handlebars (htmlbars)
  • gams
  • perl
  • jboss-cli
  • r

Affected versions: >= 9.0.0 < 10.4.1

Release notes

Sourced from highlight.js's releases.

10.4.1

Security fixes:

  • (fix) Exponential backtracking fixes for: Josh Goebel
    • cpp
    • handlebars
    • gams
    • perl
    • jboss-cli
    • r
    • erlang-repl
    • powershell
    • routeros
  • (fix) Polynomial backtracking fixes for: Josh Goebel
    • asciidoc
    • reasonml
    • latex
    • kotlin
    • gcode
    • d
    • aspectj
    • moonscript
    • coffeescript/livescript
    • csharp
    • scilab
    • crystal
    • elixir
    • basic
    • ebnf
    • ruby
    • fortran/irpf90
    • livecodeserver
    • yaml
    • x86asm
    • dsconfig
    • markdown
    • ruleslanguage
    • xquery
    • sqf

Very grateful to Michael Schmidt for all the help.

10.4.0 - November 2020

A largish release with many improvements and fixes from quite a few different contributors. Enjoy!

Deprecations:

Changelog

Sourced from highlight.js's changelog.

Version 10.4.1 (tentative)

Security

  • (fix) Exponential backtracking fixes for: Josh Goebel
    • cpp
    • handlebars
    • gams
    • perl
    • jboss-cli
    • r
    • erlang-repl
    • powershell
    • routeros
  • (fix) Polynomial backtracking fixes for: Josh Goebel
    • asciidoc
    • reasonml
    • latex
    • kotlin
    • gcode
    • d
    • aspectj
    • moonscript
    • coffeescript/livescript
    • csharp
    • scilab
    • crystal
    • elixir
    • basic
    • ebnf
    • ruby
    • fortran/irpf90
    • livecodeserver
    • yaml
    • x86asm
    • dsconfig
    • markdown
    • ruleslanguage
    • xquery
    • sqf

Very grateful to Michael Schmidt for all the help.

Version 10.4.0

A largish release with many improvements and fixes from quite a few different contributors. Enjoy!

Commits
  • e96b915 bump 10.4.1
  • 065f65f chore(release) allow release script to handle production releases
  • 68509fc chore(docs) bump SECURITY mention to 9.18.5
  • aa0fb85 chore(docs) Version 9 has reached EOL.
  • fb0a626 enh(ci): Add tests for polynomial regex issues
  • fa46dd1 fix(reasonml) fix poly backtracking issue
  • d496052 fix(latex) fix poly backtracking issue
  • d9f1cdb fix(javascript/typescript) fix poly backtracking issue
  • fdec037 fix(asciidoc) fix poly backtracking issue
  • 02ca487 fix(kotlin) fix poly backtracking issue
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by joshgoebel, a new releaser for highlight.js since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will not automatically merge this PR because it includes an out-of-range update to a production dependency.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability labels Dec 4, 2020
@dependabot-preview dependabot-preview bot mentioned this pull request Dec 4, 2020
Closed
@netlify
Copy link

netlify bot commented Dec 4, 2020 •
edited
Loading

✔️ Deploy preview for pensive-lamport-5822d2 ready!

🔨 Explore the source changes: 6cedef7

🔍 Inspect the deploy logs: https://app.netlify.com/sites/pensive-lamport-5822d2/deploys/60085f7b741f64000727ce4e

😎 Browse the preview: https://deploy-preview-378--pensive-lamport-5822d2.netlify.app

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/highlight.js-10.4.1 branch 2 times, most recently from 0cef70d to 6cedef7 Compare January 20, 2021 16:51
tubone24
tubone24 requested changes Feb 12, 2021
View reviewed changes
Copy link
Owner

@tubone24 tubone24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/highlight.js-10.4.1 branch from 6cedef7 to 2da6df2 Compare February 12, 2021 16:27
@github-actions
Copy link
Contributor

Deploy path: /home/runner/work/blog/blog/public
Functions path: /home/runner/work/blog/blog/functions/src
Configuration path: /home/runner/work/blog/blog/netlify.toml
Deploying to draft URL...

Logs: https://app.netlify.com/sites/pensive-lamport-5822d2/deploys/6026ad3b68256c0a2ce48b10
Website Draft URL: https://6026ad3b68256c0a2ce48b10--pensive-lamport-5822d2.netlify.app

If everything looks good on your draft URL, deploy it to your main site URL with the --prod flag.
netlify deploy --prod

tubone24
tubone24 approved these changes Feb 12, 2021
View reviewed changes
Copy link
Owner

@tubone24 tubone24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@tubone24 tubone24 merged commit 420ba0b into master Feb 12, 2021
@tubone24 tubone24 deleted the dependabot/npm_and_yarn/highlight.js-10.4.1 branch February 12, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tubone24 tubone24 tubone24 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tubone24